Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically add summary for archive upload and edits #969

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

psilabs-dev
Copy link
Contributor

Prior to PR, summary is not automatically added during archive file uploads (when metadata plugin is configured to run automatically) (addressed by Plugins.pm), and summary data is not automatically filled in to the summary box when editing an archive and calling metadata plugins (edit.js). This PR attempts to address that.

Contains edits (readme.js) from #968, a separate issue.

I'm not sure how do deal with rhombus git flows so I'm just keeping it linear now

Copy link
Owner

@Difegue Difegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'd missed those two!

public/js/edit.js Outdated Show resolved Hide resolved
public/js/reader.js Outdated Show resolved Hide resolved
@psilabs-dev psilabs-dev marked this pull request as draft April 20, 2024 19:36
@psilabs-dev psilabs-dev marked this pull request as ready for review April 20, 2024 20:50
@psilabs-dev psilabs-dev requested a review from Difegue April 20, 2024 20:51
@Difegue Difegue merged commit 6c2be00 into Difegue:dev Apr 22, 2024
1 check passed
@psilabs-dev psilabs-dev deleted the dev-summary-2 branch May 4, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants