refactor app load #134
Merged
refactor app load #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also fix the issue seen in #132 |
vutran
force-pushed
the
fix-linux-bg-color
branch
from
6b936cd to
7cf33d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples the
createWindow()function. This allows us to load the theme file before creating the window to set the default window's background color.The
<App />component is split into an outer and inner wrapper so we can better manage it's margins/padding for faking the squared/rounded edges with CSS border-radius.In addition, the
ResultDetailsContaineris also updated to return an empty<span />element if no details are available. This eliminates the border that is seen from the<ResultsDetails />component.