remove black border around dext #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnasa
approved these changes
Dec 10, 2016
|
It was set to 99% to allow some spacing on the side. That enabled us to have sharp edges on Mac systems. |
|
@vutran yes, I thought that value was there for a reason. Still, It have that ugly effect on Linux. |
|
I'm guessing we may have to toy around with Electron's BrowserWindow config to see if we can remove that black background. If you have time, feel free to submit something that can fix this but preserve the option to have squared edges on Macs. Otherwise, I'll take a look at this issue this week to see what we can do to resolve that issue. |
Merged
|
I think we can close this commit as this has been addressed in #134 to support both sharp/rounded edges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #119 , I described a situation that happens in Linux with a black border around dext.
Here is a screenshot:
I found it is caused by
width: 99%specified inApp.js. Any reason for that value? I have put it 100% and remove the margin-left and it fixes the black border issue.Not sure if it will have any other impacts. Please take a look.
Thank you.