Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change terminal time stamp color from bug bright red to improve readibility #708

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pkg/cli/tail.go
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ func tail(ctx context.Context, client client.Client, params TailOptions) error {
tsColor = termenv.ANSIWhite
}
if e.Stderr {
tsColor = termenv.ANSIBrightRed
tsColor = termenv.ansiCyan
Copy link
Member

@lionello lionello Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's red when the log comes from stderr but maybe the logs you're seeing shouldn't be errors?

}
var prefixLen int
trimmed := strings.TrimRight(e.Message, "\t\r\n ")
Expand Down Expand Up @@ -388,4 +388,4 @@ func isProgressDot(line string) bool {
}
stripped := term.StripAnsi(line)
return strings.TrimLeft(stripped, ".") == ""
}
}