feat: change terminal time stamp color from bug bright red to improve readibility #708
Conversation
ve-varun-sharma
changed the title
|
I agree there's improvements to be made here. Timestamps are Red for error logs, which are the only ones you'll see when you omit |
| @@ -331,7 +331,7 @@ func tail(ctx context.Context, client client.Client, params TailOptions) error { | |||
| tsColor = termenv.ANSIWhite | |||
| } | |||
| if e.Stderr { | |||
| tsColor = termenv.ANSIBrightRed | |||
| tsColor = termenv.ansiCyan | |||
There was a problem hiding this comment.
It's red when the log comes from stderr but maybe the logs you're seeing shouldn't be errors?
|
@ve-varun-sharma closing this because we did make some changes around our verbosity. Also "cyan" was already used for another column. I think there's something to be said to make timestamps optional, then this would not be an issue. |
That definitely makes sense to me! Thanks for the update here :) 🙏🏽 |
Pull Request Type
Dictionary of Definitions here:
https://ben.balter.com/2015/12/08/types-of-pull-requests/
Description
The terminal color change should improve Readability, reduced Confusion via by avoiding the use of red for timestamps, we can minimize the risk of false positives and streamline the debugging process, and overall abide by terminal UX best practices from what I understand about the objective of the time stamp purpose in the defang project.
This PR addresses this Github issue: #707
Caveats/Notes (optional)
I was not able to fully test the terminal UI as I did not run this specific defang version. Instructions on how to best run a local emulated version from VS code would be fantastic too!
Prompts (optional)
Screenshots (optional)
[Upload optional screenshots]
Checklist before requesting a review