update for handle failed deployment case #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update message to show error or success update error text update text
lionello
requested changes
Jun 26, 2024
|
I want us to fix up the existing |
update after merge update service state name
nullfunc
force-pushed
the
eric-handle-subscribe-deploy-failed-case
branch
from
968bfd5 to
4701a2b
Compare
lionello
requested changes
Jun 28, 2024
src/protos/io/defang/v1/fabric.proto
Outdated
| UNKNOWN = 0; | ||
|
|
||
| // Build states (initial state for build) | ||
| BUILD_PENDING = 1; // BUILD_QUEUED -> BUILD_ACTIVATING |
There was a problem hiding this comment.
I'm not sure why these aren't simply 1:1 the existing ones? Seems not too much gain for lot of confusion
There was a problem hiding this comment.
I was trying to map them to something platform agnostic but probably a little early to be doing that.
src/protos/io/defang/v1/fabric.proto
Outdated
| CREATED = 3; // BUILD_DEACTIVATING (done = true) | ||
|
|
||
| // Update states (initial state for existing image) | ||
| UPDATE_PENDING = 4; // UPDATE_QUEUE |
lionello
reviewed
Jul 5, 2024
src/cmd/cli/command/commands.go
Outdated
| if err := waitServiceState(ctx, defangv1.ServiceState_SERVICE_COMPLETED, serviceInfos); err != nil && !errors.Is(err, context.Canceled) { | ||
| if errors.Is(err, ErrDeploymentFailed) { | ||
| term.Warn("Deployment FAILED. Service(s) not running.") | ||
| cancelTail() |
There was a problem hiding this comment.
lionello
reviewed
Jul 5, 2024
lionello
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle FAILED deploy status
#491
DO NOT MERGE until https://github.com/DefangLabs/defang-mvp/pull/762 is approved