Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility fixes #42

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Accessibility fixes #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbe05ca
Render footer as a footer element
PetroSilenius Feb 14, 2022
68f5ffe
Hide non meaningful divider from screen readers
PetroSilenius Feb 14, 2022
d501c69
Add aria label to loading icons
PetroSilenius Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ import { Container, Divider, Grid, Link, Paper, Typography } from '@mui/material

const Header = () => {
return (
<Paper sx={{ color: 'common.black', bgcolor: '#F1F8FF' }}>
<Paper component="footer" sx={{ color: 'common.black', bgcolor: '#F1F8FF' }}>
<Container>
<Typography align="center" sx={{ p: '20px' }}>
Business Finlandin mukaan sertifiointi on laadun tae kansainvälisessä kaupassa.
Matkailualan monimuotoisuus on kuitenkin mahdollistanut sen, että myös sertifikaatin
tarjoajia on hyvin paljon. Ideana on tuottaa nyt hankalasti ja pirstoutuneena oleva tieto
yhteen paikkaan kaikkien toimijoiden avoimesti saataville.
</Typography>
<Divider sx={{ borderColor: 'common.black' }} />
<Divider sx={{ borderColor: 'common.black' }} aria-hidden="true" />
<Grid container justifyContent="space-around" sx={{ p: '10px' }}>
<Grid item>
<Link href="https://european-union.europa.eu/index_fi" color="inherit">
Expand Down
4 changes: 2 additions & 2 deletions pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const Home = ({ firstCompanies, initialResultsAmount }: HomeProps) => {
/>
{loading && offset === 0 ? (
<Grid container item alignItems="center" justifyContent="center" sx={{ marginY: '10vh' }}>
<CircularProgress />
<CircularProgress aria-label="Ladataan" />
</Grid>
) : (
<>
Expand Down Expand Up @@ -82,7 +82,7 @@ const Home = ({ firstCompanies, initialResultsAmount }: HomeProps) => {
Hae lisää
</Button>
) : (
<CircularProgress />
<CircularProgress aria-label="Ladataan" />
)}
</Grid>
)}
Expand Down