Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility fixes #42

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Accessibility fixes #42

merged 3 commits into from
Feb 15, 2022

Conversation

PetroSilenius
Copy link
Member

  • Changes footer to use the html footer element
  • Hides non meaningful divider from screen readers
  • Adds aria-label to loading icons to express its meaning to screen reader users

There was one issue with the Autocomplete component (used with city and certificate selection) where selecting an option when using Android Talkback wasn't possible. The issue comes from MUI component library and was reported there. The issue doesn't totally block Android Talkback users from using the application since typing in the field still works.

No other findings were gathered from the accessibility testing

@vercel
Copy link

vercel bot commented Feb 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dataatti/sertifikaattilukija/8NMcAJ7a47ZNWLdJXcWbz2bL2yha
✅ Preview: https://sertifikaattilukija-git-accessibility-fixes-dataatti.vercel.app

@PetroSilenius PetroSilenius merged commit ad91bc0 into main Feb 15, 2022
@PetroSilenius PetroSilenius deleted the accessibility-fixes branch February 15, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants