-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operator input/output label reactive #6581
Closed
Closed
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c09cff7
cleaning up
YohannParis 3ad9f69
Merge branch 'main' into 4756-feat-make-models-displayed-in-the-the-o…
YohannParis 759e572
Update the output on model save
YohannParis abb2e07
Merge branch 'main' into 4756-feat-make-models-displayed-in-the-the-o…
YohannParis 14b949e
Merge branch 'main' into 4756-feat-make-models-displayed-in-the-the-o…
YohannParis cd304dc
Update tera-model-from-equations-drilldown.vue
YohannParis d0a8f21
make activeProject reactive
YohannParis 81c44cd
first pass
YohannParis 1e8ec36
Merge branch '4756-feat-make-models-displayed-in-the-the-output-panel…
YohannParis 77c9535
Merge branch 'main' into operator-input/output-label-reactive
YohannParis 544e3c1
Merge branch 'main' into operator-input/output-label-reactive
YohannParis 1ebfdc1
Update workflow.ts
YohannParis 1f444cb
Merge branch 'main' into operator-input/output-label-reactive
YohannParis 2a9da80
Update project.ts
YohannParis b4ad6b3
Merge branch 'main' into operator-input/output-label-reactive
YohannParis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import { computed, shallowRef } from 'vue'; | ||
import { computed, ref } from 'vue'; | ||
import type { Project } from '@/types/Types'; | ||
|
||
export const activeProject = shallowRef<Project | null>(null); | ||
export const activeProject = ref<Project | null>(null); | ||
export const activeProjectId = computed<string>(() => activeProject.value?.id ?? ''); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a couple of extra layers of unnecessary computed going. on here, what is the problem here? The PR description is blank so I am not even sure what to test for ??