Operator input/output label reactive #6581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput-panels-of-create-model-from-equations-edit-model-and-stratify-model-fully-editable
…utput-panels-of-create-model-from-equations-edit-model-and-stratify-model-fully-editable
…utput-panels-of-create-model-from-equations-edit-model-and-stratify-model-fully-editable
…s-of-create-model-from-equations-edit-model-and-stratify-model-fully-editable' into operator-input/output-label-reactive
YohannParis
requested review from
mwdchang,
jryu01,
Tom-Szendrey,
blanchco and
mloppie
as code owners
mwdchang
reviewed
Feb 13, 2025
| // default use single output type | ||
| return useProjects().getAssetName(selectedOutput.value?.[0]) || selectedOutput.label; | ||
| const label = useProjects().getAssetName(assetId).value; | ||
| return computed(() => (!isEmpty(label) ? label : (selectedOutput.label ?? ''))); |
There was a problem hiding this comment.
There seems to be a couple of extra layers of unnecessary computed going. on here, what is the problem here? The PR description is blank so I am not even sure what to test for ??
|
The goal was to solve the issue that input/output are not reactive to change. Maybe this old PR is not worth reopening anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.