-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.7:Copter_trim #6622
base: master
Are you sure you want to change the base?
4.7:Copter_trim #6622
Conversation
0b537f2
to
c06c0fe
Compare
|
||
With auto trim the roll and pitch trim are captured as you fly in a stable hover. | ||
8. Take off again in stabilize mode and check if your copter is flying level now. If not repeat steps 4 - 7 again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or AltHold mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good with just a few corrections, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should addd "AltHold" wherever it mentions "Stabilize" mode but otherwise it looks good, thanks!
c06c0fe
to
3978750
Compare
@@ -594,6 +596,7 @@ Other functions are: | |||
ICEngine start / stop Controls ICE engine starter output :ref:`ICE engines<common-ice>` | |||
Autotune_test_gains After autotune,allows selecting tune(high) or pretune gains | |||
VTOL QuickTune Autotunes QuadPlane VTOL PIDs, see :ref:`quicktune` | |||
InFlight AHRS trim adjust Auto Trim for Copter, see :ref:`autotrim` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should unify the names. Users might not realise that "InFlight AHRS trim" is "Auto Trim" (or "Save Trim"?) and it should probably be consistent with the parameter descriprtion.
Sorry to bring it up so late in the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we would need to change the param metadata....I don't have an issue with calling the aux switch AutoTrim....we can just change it....I can do it if you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Hwurzburg, yes, let's call it AutoTrim. I've created a PR here ArduPilot/ardupilot#29352
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've actually renamed it to "AHRS AutoTrim" now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
.. youtube:: 5z0zuwicZh8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, I think these two videos are still available...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but thet are incorrect now...need to be remade with new autotrim sections... preferably as the first section...or even without save trim, as we discussed, it might be time to depricate it
3978750
to
ffc7f5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
unfortunately, the videos had to be removed...perhaps Randy or I will remake them
the MP images are out of date also, but I don't think anyone will get confused, so I did not update them...