Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zulip-integrations: Update google oauth for google calendar integration. #850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theofficialvedantjoshi
Copy link

The oauth2client library used in the google-calendar integration scripts has become deprecated. This PR updates the script to replace oauth2client with other libraries that Google is now using, specifically google-auth-httplib2 and google-auth-oauthlib.

Fixes: #847

How did you test this PR?

  • Generated a client_secret.json file from a test Google Cloud application that uses the calendar API.
  • Verified the authentication process and the creation of google-credentials.json in the home directory.
  • Tested each flag in the argument parser by specifying the hostname and port.
  • Tested the no-local-sever-auth flow in the console after obtaining an authentication code from my application's redirect URL.
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@theofficialvedantjoshi theofficialvedantjoshi force-pushed the update-google-calendar-authentication branch from 2249012 to af1090e Compare January 8, 2025 18:23
@theofficialvedantjoshi
Copy link
Author

@timabbott could you please review this PR?

@alya
Copy link
Contributor

alya commented Jan 9, 2025

@Niloth-p It would be great to get your review on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Google Calendar integration
2 participants