fix(error): Check if session is valid before calling proxy setup fn

[traeok]

Proposed changes

Fixes #3425

Also adds two unit tests for CommonApi.getSession because we didn't have any unit tests for it..

Release Notes

Milestone: 3.1.1

Changelog:

• ZE: Fixed an issue where a TypeError occurred when applying VS Code proxy settings to an invalid session.
• No changelog for ZE API (only unit tests were added)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.20%. Comparing base (96370ae) to head (1fd5c46).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3428      +/-   ##
==========================================
+ Coverage   93.18%   93.20%   +0.01%     
==========================================
  Files         120      120              
  Lines       12582    12583       +1     
  Branches     2890     2905      +15     
==========================================
+ Hits        11725    11728       +3     
+ Misses        856      854       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📅 Suggested merge-by date: 2/14/2025

[JillieBeanSim]

LGTM! thanks @traeok for the fix
We can also add this issue, I tested the scenario I mentioned the other day and this also fixes it
#3415
and this one #3337 😄

[JillieBeanSim]

Also, @traeok would you mind creating port PRs for this (once merged) and the other bug fix you mentioned for 3.1.1 please?

[zFernand0]

LGTM! 😋

[t1m0thyj]

LGTM, thanks @traeok!

[traeok]

The last merge commit into main had all passing stages. Since this last commit will not trigger the ze-build stage, I will bypass branch protections to allow this to be merged.