feat: API ML authentication provider to allow connecting to multiple instances #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -23,6 +23,7 @@ | |||
| import { ZoweExplorerExtender } from "../ZoweExplorerExtender"; | |||
| import { ZoweLogger } from "./LoggerUtils"; | |||
| import { SettingsConfig } from "./SettingsConfig"; | |||
| import { ApimlAuthenticationProvider } from "../ApimlAuthProvider"; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
Signed-off-by: Timothy Johnson <[email protected]>
| changed.push(newSession); | ||
| } | ||
| } | ||
| if (added || removed || changed) { |
Check warning
Code scanning / CodeQL
Useless conditional
| changed.push(newSession); | ||
| } | ||
| } | ||
| if (added || removed || changed) { |
Check warning
Code scanning / CodeQL
Useless conditional
Signed-off-by: Timothy Johnson <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Closing this PR and plan to split it up into smaller ones instead:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds the ApimlAuthProvider class which implements the VS Code Authentication Provider implementation so that API ML logins can be managed from the Accounts menu.
In addition, this PR adds support for connecting to multiple instances of the API ML in a single VS Code workspace and simplifies the context menu items for managing credentials.
Release Notes
Milestone:
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executedFurther comments