Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maintenance] Dependency updates for audit failures #2156

Merged
merged 5 commits into from
Feb 28, 2023

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Feb 24, 2023

Proposed changes

to release a 2.6.2 patch for the updates I cherry picked Peter's commits from #2153 and updated all CHANGELOGS creating the PR against the maintenance branch.

Release Notes

Milestone: 2.6.2

Changelog: Updated dependencies for security audits.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

phaumer and others added 3 commits February 23, 2023 10:17
Signed-off-by: Peter Haumer <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Peter Haumer <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Peter Haumer <[email protected]>
@phaumer
Copy link
Member

phaumer commented Feb 24, 2023

Thanks so much @JillieBeanSim
As @t1m0thyj mentioned, the integration tests are not used at the moment and need work, I also updated the mocha to the latest.

phaumer
phaumer previously approved these changes Feb 24, 2023
@zFernand0
Copy link
Member

Sorry for the delay, but I'm still trying out this PR.
I'll leave a proper comment in a few moments.

@zFernand0
Copy link
Member

zFernand0 commented Feb 27, 2023

I tried running the Theia tests since they were skipped on this PR.
I'm afraid I ran into a few problems 😢
The @types/mocha package seems to contain very old references which makes the code compile even with the jump from 6 to 10.
However, there were some deprecations and removals that we may need to update on this PR if we want to update the Mocha dependency.
I'll open a quick PR against this branch to discuss these changes 😋


Here is the PR:

zFernand0
zFernand0 previously approved these changes Feb 28, 2023
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Thanks for updating all of these packages 🥳

* Update mocha types

Signed-off-by: zFernand0 <[email protected]>

* forgot to force 1.34.0 for now

Signed-off-by: zFernand0 <[email protected]>

---------

Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 7 Code Smells

No Coverage information No Coverage information
14.3% 14.3% Duplication

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c9e9ccd) 73.20% compared to head (ea10d47) 73.20%.

Additional details and impacted files
@@             Coverage Diff              @@
##           maintenance    #2156   +/-   ##
============================================
  Coverage        73.20%   73.20%           
============================================
  Files               78       78           
  Lines             8073     8073           
  Branches          1715     1715           
============================================
  Hits              5910     5910           
  Misses            2163     2163           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zFernand0
Copy link
Member

FYI, All code smells and duplication are coming from our integration tests.
I believe we can address these items when we work on the following issues:

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @phaumer and @zFernand0 for removing so many resolutions in package.json 🙂

@zFernand0 zFernand0 merged commit 85a786d into maintenance Feb 28, 2023
@zFernand0 zFernand0 deleted the dep-update-patch branch February 28, 2023 19:56
@JillieBeanSim JillieBeanSim mentioned this pull request Mar 3, 2023
16 tasks
@JillieBeanSim JillieBeanSim added this to the v2.6.2 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants