-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maintenance] Dependency updates for audit failures #2156
Conversation
Signed-off-by: Peter Haumer <[email protected]> Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Peter Haumer <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Peter Haumer <[email protected]>
Thanks so much @JillieBeanSim |
Sorry for the delay, but I'm still trying out this PR. |
I tried running the Theia tests since they were skipped on this PR. Here is the PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Thanks for updating all of these packages 🥳
* Update mocha types Signed-off-by: zFernand0 <[email protected]> * forgot to force 1.34.0 for now Signed-off-by: zFernand0 <[email protected]> --------- Signed-off-by: zFernand0 <[email protected]> Signed-off-by: Fernando Rijo Cedeno <[email protected]>
5df2e1a
to
ea10d47
Compare
SonarCloud Quality Gate failed.
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## maintenance #2156 +/- ##
============================================
Coverage 73.20% 73.20%
============================================
Files 78 78
Lines 8073 8073
Branches 1715 1715
============================================
Hits 5910 5910
Misses 2163 2163 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
FYI, All code smells and duplication are coming from our integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @phaumer and @zFernand0 for removing so many resolutions in package.json 🙂
Proposed changes
to release a 2.6.2 patch for the updates I cherry picked Peter's commits from #2153 and updated all CHANGELOGS creating the PR against the
maintenance
branch.Release Notes
Milestone: 2.6.2
Changelog: Updated dependencies for security audits.
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments