Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fix for data set copy regression #2402

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Implement fix for data set copy regression #2402

merged 3 commits into from
Jan 3, 2025

Conversation

awharn
Copy link
Member

@awharn awharn commented Jan 3, 2025

What It Does

Implements a fix to a regression that was found in the Data set copy functionality where, if members were specified and a PDS member was being copied to a PDS member, the whole PDS would be copied. Also fixes related system test failures.

How to Test

  • Install from master
  • Copy a PDS member to a different PDS
  • List the PDS and see multiple members were copied
  • Install from this branch
  • Copy a PDS member to a different PDS
  • Notice only the PDS member specified was copied

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <[email protected]>
@awharn awharn self-assigned this Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

📅 Suggested merge-by date: 1/17/2025

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM - when copying one PDS member to another on this branch, the contents of the "destination" member are replaced as expected, and the rest of my PDS remains intact.

Thanks for the fix Andrew!

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (e8939d8) to head (2e8a27a).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2402    +/-   ##
========================================
  Coverage   91.28%   91.28%            
========================================
  Files         638      638            
  Lines       18206    18207     +1     
  Branches     3930     3823   -107     
========================================
+ Hits        16619    16620     +1     
  Misses       1586     1586            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn!

Copy link
Contributor

@pujal0909 pujal0909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this fix!

@awharn awharn requested a review from anaxceron January 3, 2025 20:11
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@awharn awharn merged commit 38b6ef8 into master Jan 3, 2025
23 checks passed
@awharn awharn deleted the fix-dataset-copy branch January 3, 2025 20:58
@awharn awharn added the release-patch Indicates a patch to existing code has been applied label Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

6 participants