-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fix for data set copy regression #2402
Conversation
Signed-off-by: Andrew W. Harn <[email protected]>
📅 Suggested merge-by date: 1/17/2025 |
Signed-off-by: Andrew W. Harn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM - when copying one PDS member to another on this branch, the contents of the "destination" member are replaced as expected, and the rest of my PDS remains intact.
Thanks for the fix Andrew!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2402 +/- ##
========================================
Coverage 91.28% 91.28%
========================================
Files 638 638
Lines 18206 18207 +1
Branches 3930 3823 -107
========================================
+ Hits 16619 16620 +1
Misses 1586 1586
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @awharn!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Implements a fix to a regression that was found in the Data set copy functionality where, if members were specified and a PDS member was being copied to a PDS member, the whole PDS would be copied. Also fixes related system test failures.
How to Test
master
Review Checklist
I certify that I have:
Additional Comments