Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup to use constants #240

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor cleanup to use constants #240

wants to merge 1 commit into from

Conversation

enamkhan
Copy link
Contributor

@enamkhan enamkhan commented Feb 28, 2025

Would like to use constants where possible so this is just a bit of minor cleanup.

Review Checklist
I certify that I have:

Additional Comments

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.80%. Comparing base (2d13589) to head (7e145a2).

Files with missing lines Patch % Lines
...ees/CICSCombinedTrees/CICSCombinedLocalFileTree.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   40.78%   40.80%   +0.02%     
==========================================
  Files         151      151              
  Lines        5056     5058       +2     
  Branches      817      860      +43     
==========================================
+ Hits         2062     2064       +2     
  Misses       2994     2994              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AndrewTwydell AndrewTwydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks, good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants