show logs initial implementation #237
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 40.78% 40.99% +0.20%
==========================================
Files 151 152 +1
Lines 5056 5111 +55
Branches 817 874 +57
==========================================
+ Hits 2062 2095 +33
- Misses 2994 3016 +22 ☔ View full report in Codecov by Sentry. |
davenice
force-pushed
the
niced-open-logs-for-region
branch
from
5b2c38f to
f18c534
Compare
| export async function findRelatedZosProfiles(cicsProfile: IProfileLoaded, zosProfiles: IProfileLoaded[]): Promise<IProfileLoaded> { | ||
| const baseForCicsProfile = await ProfileManagement.getProfilesCache().fetchBaseProfile(cicsProfile.name); | ||
|
|
||
| // find all zosmf and rse profiles (put zosmf first) | ||
| zosProfiles = zosProfiles.sort((prof) => (prof.profile.type === "zosmf" ? -1 : 1)); | ||
|
|
||
| // filter out profiles that are not in the same base as the cics profile | ||
| const matchingProfiles: IProfileLoaded[] = []; | ||
| if (baseForCicsProfile) { | ||
| for (const profile of zosProfiles) { | ||
| if (baseForCicsProfile && baseForCicsProfile?.name === (await ProfileManagement.getProfilesCache().fetchBaseProfile(profile.name))?.name) { | ||
| matchingProfiles.push(profile); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
@JillieBeanSim / @zFernand0 - this is the part of the PR I'm particularly interested in your thoughts on.
I'm taking a CICS profile and a list of proposed zosProfiles.
I want to identify a zosProfile that matches the CICS profile. I'm currently doing this by requesting the base profile for each proposed zosProfile to see if it matches the base profile of the cicsProfile.
Is this the best way, currently?
There was a problem hiding this comment.
For Profiles that match a particular CICS profile you may want to use ProfilesCache.fetchAllProfiles() then filter down to the profiles with matching host. Also, depending on the scenario you may want to filter even further on profile types you may want to support removing types like TSO, SSH or what doesn't fit. All these profiles will already have any merging done if needed, relying on base profile can prove to be troublesome since users configure their Zowe Config in different ways and sometimes without base profiles.
There was a problem hiding this comment.
if you know the profile type there is also ProfilesCache.fetchAllProfilesByType(type) returning complete/merged profiles
There was a problem hiding this comment.
Thanks Billie - I started with fetchAllProfilesByType, running it twice for z/OSMF and RSE but decided it was easier to just fetch all profiles and filter within our code (
)So zooming out a bit the logic I've used is:
- Try and use the base profile to identify a connection within the same nested group ( )
- If not found, find a connection that uses the same hostname ( )
- If not found, offer the user all z/OSMF and RSE connections to pick from ( )
So I think the summary is that you're saying there isn't a better way :-( , and that the code does deal with your concerns, which is good :-)
Let me know if anything else occurs. 👍
davenice
force-pushed
the
niced-open-logs-for-region
branch
from
4ac2de7 to
57dee9e
Compare
|
Here is a quick vid showing what this does and why it's not exactly what @Joe-Winchester suggested in the original issue :-) Happy, @Joe-Winchester ? (edit: whoops - uploaded the wrong version first time - this one has sound where I explain the scenarios I show!) |
linting changelog more unit tests don't offer zos profiles that aren't authenticated Signed-off-by: Dave Nice <[email protected]>
Co-authored-by: Andrew <[email protected]> Signed-off-by: Dave Nice <[email protected]>
Signed-off-by: Dave Nice <[email protected]>
davenice
force-pushed
the
niced-open-logs-for-region
branch
from
d1f3e9b to
dd807f7
Compare
What It Does
Addresses #56
Review Checklist
I certify that I have:
Additional Comments