Using real data for unit test mocking

[AndrewTwydell]

What It Does
Adapts SDK unit tests to use real CMCI responses for a more accurate behaviour.

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

Additional Comments

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.56%. Comparing base (b51d5c2) to head (fe88b40).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   28.56%   28.56%           
=======================================
  Files         147      147           
  Lines        5031     5031           
  Branches      882      881    -1     
=======================================
  Hits         1437     1437           
  Misses       3594     3594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[davenice]

This looks good!

Great to use actual data.

We might find in the future we need to have specific data per test, rather than a generic set of mocks, but I imagine that the generic set will do us for a while!

[AndrewTwydell]

@zFernand0 I'd like to run this by you, now that I've marked it ready for review - the only potential contentious point would be that I've changed the method we're mocking here.

We're unit testing getResource still, but I'm now mocking the XML response rather than the JSON parsed version of the XML, so if anything I'm now testing more?? The idea behind this was so we can test real CMCI error messages more easily, but I'd like to know if you're onboard with this style of testing or not! 😀

[traeok]

LGTM, thanks @AndrewTwydell!

[zFernand0]

LGTM! 😋

Apologies for the late review 😓

[zFernand0]

I really like this approach 🙏
Thanks for adding the mock responses 🙏