Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x lazy batching backport #77

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from

Conversation

pgrunewald
Copy link

Includes the backport for lazy batching, see: #75

@icemac icemac requested review from dataflake and d-maurer October 14, 2024 06:56
Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but I don't know why this is needed on such an old branch. I certainly don't have an interest in making a release from that.

@d-maurer
Copy link
Contributor

but I don't know why this is needed on such an old branch.

Likely for Python 2.7 support (potentially still in use with Plone 5.2).

@dataflake
Copy link
Member

I'm just concerned that making a release from this branch signals that it is still supported. If someone else steps up if there are issues and provides support, feel free. I personally don't want to support this old version anymore.

@pgrunewald
Copy link
Author

This PR is indeed for the Python 2.7 support, since our setup relies on it. We are still in the process of migrating to Python 3, but it still takes time, until this will happen. For that duration it's nice to have this bugfix in place.

I completely understand, if you do not wish to support/release this for legacy systems. In that case we'd rely on our fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants