-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker compose #28
base: master
Are you sure you want to change the base?
Conversation
@zopanix The Travis-CI build is failing because the environment variables haven't been configured in travis. Can you set that up please? |
Hey, the env vars are set, it should work now |
I don't believe using Travis CI is the best tool to build images automatically and put them in Docker Hub since Docker Hub themselves support github integration and automatic builds of images... So unless Travis CI is running some tests on the image, I don't think it should be used at all. |
The value Travis-CI adds over Dockerhub is that it can tag the images in accordance with the GitHub release version number. Dockerhub isn't capable of this kind of integration. |
You're totally right, I don't remember seeing this. This could replace the travis integration. The full docs are here: https://docs.docker.com/docker-hub/github/ |
@RCM7 @bkuhl : I already tried using docker build tools but it didn't work that well. I don't have as many options as you show on your screenshot and, while everything is configured correctly, I've never seen an automated build starting on its own. That's why I've chosen travis ci to manage this. |
@zopanix I understand that. I tried to reproduce the steps in a dummy project, and while some may seem confusing, it all checked out and it works. If you'd give it a try I'm glad to help with anything :) |
Ping 😄 |
Upgrading this would be on @zopanix unless he wants to give me access to the Dockerhub repo as well. |
Hey, sorry I've been inactive bud I'm getting installed in my new home. I moved to canada from France it will take me a week or two to be completely operationnal :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to remove the default network and overridden environment variables.
- factorio_net | ||
restart: always | ||
|
||
networks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to specify a network as one is automatically created with bridge
type.
- ./mods:/opt/factorio/mods | ||
ports: | ||
- "34197:34197/udp" | ||
environment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defaults for the environment are already provided in the Dockerfile, is there a need to redefine them?
Fix image comment to new version of factorio
This was caused because when building on master, the travis_tag variable is empty, causing the build to fail
Fix image comment to new version of factorio
…server into add-docker-compose
Sorry for the delay, I was out in vacation and then too occupied catching up with work 😄 |
Basically I added the docker-compose I usually use to spin up my game server.
This way all the mounts, port mapping, environment variables and build step is handled by docker-compose and specified in this file, reducing the size of the commands to something like:
Any doubts just ask, but don't skip a look at the docker-compose documentation if you don't understand something.
Cheers