fix(graphical): prevent leading newline when no link/code #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this bug is the cause of the regression blocking our upgrade in astral-sh/uv#9568 — many snapshots changed :) |
|
@zanieb do you think you could run your test suite against this PR and see if it does actually fix the issue? It does seem to be the same thing though but I want to avoid thrash if possible |
zkat
approved these changes
Jan 14, 2025
|
Yep this looks good to me astral-sh/uv#10608 |
|
@zanieb thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#358 introduced a new behavior: if a diagnostic has no
code, the rendered report will contain a leading newline.I'm not sure if this was an intentional change or an unintended side effect, but as a long-time miette user, I wouldn't expect my rendered report to include an extra leading newline - whether I'm outputting to the terminal, displaying in web page, or running snapshot tests. So I opened this PR.
Please let me know if I've misunderstood anything.