Update from upstream #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can capture the first identifier with a separate metavariable, and then put it at the end of the enum.
Fixed handling of trailing commas in matcher. Co-authored-by: Lukas Wirth <[email protected]>
The hack example comes from rust-lang/rust#95860.
Better reflects natural ordering of numbers
…ng it I missed this change due to the annotation not being there
For code hidden with `#` there must be a space after the `#`.
I had to do this myself recently and when I looked in this chapter it was "WIP" so I had to work it out myself. Might as well record it for the benefit of others.
`mdbook test` reports lots of errors. This commit fixes them, in various ways. - Add space after `#` on hidden lines. - Add `compile_fail` to all examples that are intended to not compile. - Add `text` to non-code blocks. - Add `ignore` to examples using `#![feature(...)]`, which requires nightly. Unfortunate, but I can't see a better way to handle these. - Add `edition2021` where necessary. - Add necessary hidden code.
`mdbook test` isn't run on CI! It should be. Plus some other CI improvements, based on the equivalent file at `github.com/nnethercote/perf-book/`: - Run actions on pull requests, to allow tests to run before merging. - Add some missing names for steps. - Update `actions/checkout` from v2 to v3.
this is also seen in the recent stabilization PR attempt: rust-lang/rust#122808 and rust playground confirms it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.