Unblock history render #520
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 build.zip [updated at May 31, 1:02:52 PM UTC] |
zerts
force-pushed
the
task/extension-refactor-history-render-to-remove-initial-delay-WLT-4928
branch
from
c90d794 to
2244959
Compare
| @@ -75,7 +81,9 @@ function ActionTitle({ | |||
|
|
|||
| return ( | |||
| <UIText kind="body/accent"> | |||
| {explorerUrl ? ( | |||
| {!actionTitle ? ( | |||
| <DelayedRender delay={1000}>[Missing network data]</DelayedRender> | |||
There was a problem hiding this comment.
should there be a placeholder so that the element height doesn't change after delay?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.