Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fat: fat_fs_api reduce the wipe partition sects #84429

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hakehuang
Copy link
Collaborator

@hakehuang hakehuang commented Jan 23, 2025

As SD partition tables, GPT or MBT, is positioned at the beginning of a device
it is enough to wipe first 64 sectors, of 512 bytes.
Wipe of entire SD card is very slow and unnecessary.

fixes: #84428

@de-nordic
Copy link
Collaborator

@hakehuang Can you provide some better commit message? I only understand the second line.
You mean to erase FAT or MBT/GPT only?

@hakehuang hakehuang force-pushed the reduce_fat_wape_partition_size branch from 01247b9 to d4f0338 Compare January 23, 2025 11:32
@hakehuang
Copy link
Collaborator Author

@hakehuang Can you provide some better commit message? I only understand the second line.
You mean to erase FAT or MBT/GPT only?

@de-nordic , thanks for checking, I update the commit message. it is for GPT as MBT is the first LBA0 in GPT in 128 bytes. and usually 32k is large enough to have all partitions.

@de-nordic
Copy link
Collaborator

@hakehuang Can you provide some better commit message? I only understand the second line.
You mean to erase FAT or MBT/GPT only?

@de-nordic , thanks for checking, I update the commit message. it is for GPT as MBT is the first LBA0 in GPT in 128 bytes. and usually 32k is large enough to have all partitions.

May I suggest rephrasing commit message from:

as sd partition including GPT(MBT at LBA0) will no larger than 32K
so only wape 64 sector in 512 byte is enought.
wape all sd card will be very slow, and unnecessary.

to

As SD partition tables, GPT or MBT, is positioned at the beginning of a device
it is enough to wipe first 64 sectors, of 512 bytes.
Wipe of entire SD card is very slow and unnecessary.

?
And change "wape" to "wipe", in commit subject. I do not want FS test to do that thing around any part of a device.

Thanks.

@hakehuang hakehuang changed the title tests: fat: fat_fs_api reduce the wape partition sects tests: fat: fat_fs_api reduce the wipe partition sects Jan 23, 2025
@hakehuang hakehuang force-pushed the reduce_fat_wape_partition_size branch from d4f0338 to 15a272a Compare January 23, 2025 12:20
@hakehuang
Copy link
Collaborator Author

to

As SD partition tables, GPT or MBT, is positioned at the beginning of a device
it is enough to wipe first 64 sectors, of 512 bytes.
Wipe of entire SD card is very slow and unnecessary.

? And change "wape" to "wipe", in commit subject. I do not want FS test to do that thing around any part of a device.

@de-nordic updated, thanks a lot for your suggestion.

As SD partition tables, GPT or MBT, is positioned at
the beginning of a device, it is enough to wipe first 64 sectors,
of 512 bytes. Wipe of entire SD card is very slow and unnecessary.

fixes: zephyrproject-rtos#84428

Signed-off-by: Hake Huang <[email protected]>
@hakehuang hakehuang force-pushed the reduce_fat_wape_partition_size branch from 15a272a to 15a1c22 Compare January 23, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: tests/subsys/fs/fat_fs_api/filesystem: fat: api test Timeout
4 participants