Merge pull request #3017 from zendesk/gurney/removeStatusRefEscape

Remove CGI escape from ref in GitHub check API call
zendesk · Oct 23, 2018 · cd65739 · cd65739
2 parents db768fa + 691d9f4
commit cd65739
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/models/commit_status.rb b/app/models/commit_status.rb
@@ -71,7 +71,7 @@ def github_state
   # transition to new API. See https://developer.github.com/v3/checks/runs/ and
   # https://developer.github.com/v3/checks/suites/ for details
   def github_check
-    base_url = "repos/#{@project.repository_path}/commits/#{CGI.escape(@reference)}"
+    base_url = "repos/#{@project.repository_path}/commits/#{@reference}"
     preview_header = {Accept: 'application/vnd.github.antiope-preview+json'}
 
     check_suites = GITHUB.get("#{base_url}/check-suites", headers: preview_header)[:check_suites]