Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python requirement to 3.9 #47

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

timwoj
Copy link
Member

@timwoj timwoj commented Dec 3, 2024

Part of zeek/zeek#3239

@timwoj timwoj force-pushed the topic/timw/python-upgrade branch from cc27c2b to 6ce8020 Compare December 3, 2024 20:50
Copy link
Member

@bbannier bbannier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I confirmed that this works on my machine with python-3.13.0.

@@ -21,7 +21,7 @@ def main():
# Set a fixed number of columns to avoid output discrepancies between
# invocation at the shell vs via CI tooling. This only affects how the
# manpage is written to disk, not how it renders at the terminal.
os.environ["COLUMNS"] = "80"
os.environ["COLUMNS"] = "200"
Copy link
Member

@bbannier bbannier Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursed, but required since argparse_manpage starts adding line breaks with python-3.13 without this 🙈.

@timwoj timwoj merged commit ff32a14 into master Dec 3, 2024
5 checks passed
@timwoj timwoj deleted the topic/timw/python-upgrade branch December 3, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants