zeek-archiver: Respect umask setting #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
awelzel
changed the title
awelzel
force-pushed
the
topic/awelzel/57-relax-mkdir-open-permissions
branch
from
4f8e652 to
2a247ee
Compare
Rather than hard-coding 0700 and 0644, use 0775 and 0664 and assume and rely on open() and mkdir() to pick up the environment's umask value. This may break someone relying on the strict permissions, but I'd argue it's not worth a configuration option. And pointing them at umask may be pragmatic enough. Closes #57.
awelzel
force-pushed
the
topic/awelzel/57-relax-mkdir-open-permissions
branch
from
ce012f8 to
8e02215
Compare
timwoj
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than hard-coding 0700 and 0644, use 0775 and 0664 and assume and rely on open() and mkdir() to pick up the environment's umask value.
This may theoretically break someone relying on the strict permissions, but I'd argue it's not worth a configuration option. And pointing them at umask may be pragmatic enough.
Closes #57.