update-changes: Warn if gawk is missing #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It took a bit until I realized my CHANGES entries to Zeek didn't include the GH-1234 prefixes. Seems reasonable to expect gawk to be installed.
bbannier
reviewed
Jan 11, 2024
| @@ -606,6 +606,11 @@ fi | |||
|
|
|||
| echo | |||
| echo Type Enter to edit new $file_changes, or CTRL-C to abort without any modifications. | |||
| if ! command -v gawk; then | |||
There was a problem hiding this comment.
I cannot say how reasonable it is to expect gawk, but if we made this change we should also remove the redundant check in default_format_msg.
There was a problem hiding this comment.
Let me close this PR. This was a knee-jerk reaction after finding an optional dependency changes the formatting of the output silently. And yeah, either we should fully require it or not change anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took a bit until I realized my CHANGES entries to Zeek didn't include the GH-1234 prefixes. Seems reasonable to expect gawk to be installed.