Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reports: Caps fixed for Section Selections of the Report Generation Template #6095

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bj-taduran
Copy link

Overview

What: Attempted to fix title caps.
Where: Zap App > Report (menu bar) > Generate Report > Template > Sections
Selection_007

Copy link

github-actions bot commented Jan 14, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@bj-taduran
Copy link
Author

bj-taduran commented Jan 14, 2025

Hello ZAP team!

I am a new contributor and desiring to grow my knowledge about the ZAP code base to provide more significant contributions in the future. I decided to start with fixing title caps as mentioned in issue 2000.

I am certain what Messages.properties to change as I have submitted here.
However, after building zap-extension through "./gradlew addOns:reports:copyZapAddOn"
and building zaproxy "./gradlew build"

"./gradlew run" on zaproxy project doesn't reflect the changes made.

Could you point me to the documentation on how to test my changes?

@bj-taduran
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@psiinon
Copy link
Member

psiinon commented Jan 14, 2025

Logo
Checkmarx One – Scan Summary & Details02b55a7d-5f2c-41cc-bc12-f5d024bdc503

Great job, no security vulnerabilities found in this Pull Request

@kingthorin
Copy link
Member

kingthorin commented Jan 14, 2025

If you run ZAP then press ctrl + l (that's an L) then navigate to the build location (something like: C:\Users\user\Desktop\zap-ws\zap-extensions\addOns\reports\build\zapAddOn\bin ) you can select the newly built add-on and load it.
(In you may need to close and re-launch ZAP in order to see the changes, after having loaded the add-on).

@kingthorin
Copy link
Member

The CHANGELOG: https://github.com/zaproxy/zap-extensions/blob/main/addOns/reports/CHANGELOG.md should also be updated. In the "Unreleased" section add a ### Changed heading and a bullet that describes the change and references the issue (just read older entries for inspiration).

@bj-taduran
Copy link
Author

Selection_010
Seeing that through was so satisfying. I earlier tried ./gradlew addOns:reports:install --port 8080 but it was giving SocketException error. Ctrl+L was a nifty tip.

I've done the CHANGELOG as well. I wasn't convinced that this was a significant change for the CHANGELOG but there, added it now.

Thanks @kingthorin .

@thc202 thc202 changed the title Caps fixed for Section Selections of the Report Generation Template reports: Caps fixed for Section Selections of the Report Generation Template Jan 15, 2025
@thc202
Copy link
Member

thc202 commented Jan 15, 2025

#6095 (comment)

Ensure you provide the right API key or disable it.

@bj-taduran
Copy link
Author

bj-taduran commented Jan 16, 2025

Hi, @kingthorin , @thc202

Just checking if I am still missing anything for this change to be approved.
The API key is for testing the change, right? Or did I misunderstand something?

@kingthorin
Copy link
Member

It just needs a second review. The changelog is a bit verbose but 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants