-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: enhance README with detailed installation guide and features #1194
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @crStiv on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
Hello @crStiv , thank you for your contribution can you sign our cla (cc @aquint-zama ) and I let @yuxizama who is in charge of our documentation to review your commit. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@aquint-zama @BourgerieQuentin I suppose the CLA was subscribed? |
indeed it's all good, you could see the label on the PR automatically added by our CLA bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @crStiv, thank you so much for your contribution. 💛
README.md
Outdated
- 📊 Built-in performance analysis tools | ||
- 🔄 Seamless integration with existing Python code | ||
|
||
### System Requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just recommend moving ### System Requirments under ##Getting Started.
The rest is all good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuxizama made an update
README.md
Outdated
|
||
| Concrete Version | Python Version | CUDA Support | | ||
|-----------------|----------------|--------------| | ||
| 2.0.0 | 3.8 - 3.11 | ≥ 11.8 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we support 3.12 as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we support 3.12 as well
@bcm-at-zama made an update
Description:
This commit aims to make the README more informative and user-friendly,
helping new contributors and users better understand the project's
capabilities and requirements.