Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: enhance README with detailed installation guide and features #1194

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

crStiv
Copy link

@crStiv crStiv commented Jan 12, 2025

Description:

  • Add Key Features section highlighting main capabilities
  • Improve installation instructions with GPU/CPU variants
  • Add system requirements and Python version compatibility
  • Include version compatibility matrix
  • Enhance readability of installation options
  • Update documentation structure for better navigation

This commit aims to make the README more informative and user-friendly,
helping new contributors and users better understand the project's
capabilities and requirements.

Copy link

cla-bot bot commented Jan 12, 2025

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @crStiv on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@BourgerieQuentin
Copy link
Member

Hello @crStiv , thank you for your contribution can you sign our cla (cc @aquint-zama ) and I let @yuxizama who is in charge of our documentation to review your commit.

@aquint-zama
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jan 20, 2025
Copy link

cla-bot bot commented Jan 20, 2025

The cla-bot has been summoned, and re-checked this pull request!

@crStiv
Copy link
Author

crStiv commented Jan 20, 2025

@aquint-zama @BourgerieQuentin I suppose the CLA was subscribed?

@aquint-zama
Copy link
Contributor

@aquint-zama @BourgerieQuentin I suppose the CLA was subscribed?

indeed it's all good, you could see the label on the PR automatically added by our CLA bot

Copy link
Contributor

@yuxizama yuxizama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @crStiv, thank you so much for your contribution. 💛

README.md Outdated
- 📊 Built-in performance analysis tools
- 🔄 Seamless integration with existing Python code

### System Requirements
Copy link
Contributor

@yuxizama yuxizama Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just recommend moving ### System Requirments under ##Getting Started.
The rest is all good to me.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuxizama made an update

README.md Outdated

| Concrete Version | Python Version | CUDA Support |
|-----------------|----------------|--------------|
| 2.0.0 | 3.8 - 3.11 | ≥ 11.8 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we support 3.12 as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we support 3.12 as well

@bcm-at-zama made an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants