-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend MaintenanceWindows parameter usage #2810
Conversation
7fade35
to
5cab328
Compare
👍 |
If I recall correctly moving the primary is a once or never operation. Removing the node readiness label triggers an node event which the operator is listening on to perform the migration. If the migration does not work the operator will not try again, because no other node event is send. Hence the primary stays on the node and blocks further operators by the K8s admins. We have seen it in the past where we were asked to trigger a switchover to unblock K8s updates. Therefore, I think we greatly increase the possibility that pod migrations will not happen at all if they are omitted due to maintenance window restrictions. However, we could instead mark the primary pod to be rotated so another sync will trigger a switchover so that the old instance can be removed by K8s drainage. |
04a488a
to
f488bee
Compare
f488bee
to
9689f25
Compare
af7057b
to
9e926d8
Compare
9e926d8
to
3265113
Compare
We have to update reference docs and also sections that talk about rolling updates like in admin docs. About user docs I'm not sure. So far they do not mention maintenance windows at all. |
88b9845
to
88b1931
Compare
Co-authored-by: Felix Kunde <[email protected]>
👍 |
1 similar comment
👍 |
Consider maintenance window when migrating master pods and replacing pods (rolling update)