Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement version change check in CI. #17

Merged
merged 3 commits into from
May 21, 2019
Merged

Implement version change check in CI. #17

merged 3 commits into from
May 21, 2019

Conversation

bmaher
Copy link
Contributor

@bmaher bmaher commented May 21, 2019

Signed-off-by: Brian Maher [email protected]

Part of #6. Automated version updated check.

Description

This PR adds a new script check_version.sh that checks if the version number in the pyproject.toml file has been updated since the last merge. The idea is to automate a check that is currently the responsibility of the reviewer for every PR.

Types of Changes

What types of changes does your code introduce? Keep the ones that apply:

  • Configuration change

TODO

List of tasks you will do to complete the PR:

  • Increment version number, currently set to same as old to prove the script works.

Review

Reviewers' checklist:

  • If this PR implements new flows or changes existing ones, are there
    good tests for these flows?
    If this PR rather removes flows, are the obsolete tests removed as well?
  • Is the documentation still up-to-date and exhaustive? This covers both
    technical (in source files) and functional (under docs/) documentation.
  • Is the changelog updated?
  • Does the new version number correspond to the actual changes from this PR?
    In doubt, refer to https://semver.org.

@zincr
Copy link

zincr bot commented May 21, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@bmaher
Copy link
Contributor Author

bmaher commented May 21, 2019

@thilp @tortila What do you think of such a check? In Zelt, the only file that needs to be updated each PR merge is the pyproject.toml file (and the CHANGELOG of course...). Therefore, I don't think Zelt needs the same version updating script that Transformer has. However, I would like to make the updating of the version something that isn't always on the reviewer to check manually (or for the deploy script to fail on).

Signed-off-by: Brian Maher <[email protected]>
@bmaher bmaher marked this pull request as ready for review May 21, 2019 10:57
@bmaher bmaher requested review from thilp and tortila May 21, 2019 10:57
@bmaher bmaher merged commit 0242d1a into master May 21, 2019
@bmaher bmaher deleted the version_check branch May 21, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants