-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test custom AMI for EFA support #8623
Open
mikkeloscar
wants to merge
4
commits into
eks
Choose a base branch
from
datalab-test-efa-testing
base: eks
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
added
do-not-merge
major
Major feature changes or updates, e.g. feature rollout to a new country, new API calls.
labels
Dec 10, 2024
mikkeloscar
force-pushed
the
datalab-test-efa-testing
branch
5 times, most recently
from
December 12, 2024 08:41
c25d2fa
to
01245c9
Compare
desinurch
force-pushed
the
datalab-test-efa-testing
branch
from
December 12, 2024 11:36
f51fc7b
to
9d01fb7
Compare
@desinurch FYI: I merged latest beta branch into this one to keep it up to date. |
mikkeloscar
force-pushed
the
datalab-test-efa-testing
branch
from
January 7, 2025 10:04
88bf69f
to
01a7d8b
Compare
mikkeloscar
force-pushed
the
datalab-test-efa-testing
branch
9 times, most recently
from
January 10, 2025 13:44
01735b8
to
597046b
Compare
mikkeloscar
force-pushed
the
datalab-test-efa-testing
branch
9 times, most recently
from
January 13, 2025 14:12
0c81ee6
to
fdbda79
Compare
mikkeloscar
force-pushed
the
datalab-test-efa-testing
branch
7 times, most recently
from
January 20, 2025 13:55
ccfd76a
to
7b29f32
Compare
mikkeloscar
force-pushed
the
datalab-test-efa-testing
branch
from
January 21, 2025 15:37
7b29f32
to
b2ceffc
Compare
@desinurch This PR is not in a mergable state, just enabled for testing. We need to update the main AMI which we can't do without rolling the nodes, so it must be either done e.g. with Kubernetes v1.32 (or other changes) or we split out the GPU AMI as we discussed and then we can make a PR just for GPU AMI update. |
mikkeloscar
force-pushed
the
datalab-test-efa-testing
branch
from
January 22, 2025 13:22
b2ceffc
to
4528187
Compare
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
force-pushed
the
datalab-test-efa-testing
branch
from
January 22, 2025 14:23
4528187
to
694c41f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do-not-merge
major
Major feature changes or updates, e.g. feature rollout to a new country, new API calls.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is purely for enabling testing of an in-progress AMI to enable support for EFA on
g5
andp5
instances.The idea is that a cluster switched to this PR branch will be able to run a node-pool like this:
With will run the special AMI defined as:
kuberuntu_image_v1_31_jammy_with_gpu_amd64
. To change the AMI to test, only that config-item needs to be changed in this PR and the node pool will be updated.