Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: 시간표 조회 API 구현 #23

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Feat: 시간표 조회 API 구현 #23

merged 7 commits into from
Feb 4, 2025

Conversation

DWL21
Copy link
Collaborator

@DWL21 DWL21 commented Feb 3, 2025 •
edited
Loading

Closes #22
=> 과목 수강 대상을 함께 반환하지 않아요. 왜냐하면 시간표 도메인에 학과 정보가 없어 학과에 해당하는 수강 대상을 반환할 수 없기 때문입니다.

@DWL21 DWL21 added the ✨ Feature 기능 추가 & 수정 label Feb 3, 2025
@DWL21 DWL21 requested a review from chaeyeon0130 February 3, 2025 08:30
@DWL21 DWL21 self-assigned this Feb 3, 2025
chaeyeon0130
chaeyeon0130 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@chaeyeon0130 chaeyeon0130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피그마 상, 시간표에 target 정보가 필요하지 않기 때문에 반환하지 않아도 괜찮을 것 같네요! 수고하셨습니다

@DWL21 DWL21 merged commit f46a7ee into main Feb 4, 2025
1 check passed
@DWL21 DWL21 deleted the feat/timetable branch February 4, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeyeon0130 chaeyeon0130 chaeyeon0130 approved these changes

Assignees

@DWL21 DWL21

Labels
✨ Feature 기능 추가 & 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: 시간표 조회 구현
2 participants
@DWL21 @chaeyeon0130