Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to removing DebugIdGenerator from Yii Debug #150

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Jan 14, 2025

Q A
Is bugfix?
New feature?
Breaks BC? ✔️

Related to yiisoft/yii-debug#299

@vjik vjik added the status:code review The pull request needs review. label Jan 14, 2025
@vjik vjik requested a review from a team January 14, 2025 19:24
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 10.21%. Comparing base (0417e56) to head (a47b5e2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Debug/Middleware/DebugHeaders.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #150      +/-   ##
============================================
+ Coverage     10.15%   10.21%   +0.05%     
- Complexity      266      267       +1     
============================================
  Files            26       26              
  Lines          1349     1351       +2     
============================================
+ Hits            137      138       +1     
- Misses         1212     1213       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 48981f7 into master Jan 15, 2025
17 checks passed
@vjik vjik deleted the id-generator branch January 15, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants