-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use latest Omnisharp-rosyln for .NET 6 support #1659
base: master
Are you sure you want to change the base?
Conversation
Thanks! Sorry for the delay - I've been on vacation and had covid. Worth me looking at it now, or wait for the issues to be resolved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW the changes look ok to me
Reviewable status: 0 of 2 LGTMs obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @mispencer)
I can confirm the .NET 6.0 (non-mono) version works for me on Arch Linux and Gentoo Linux.
This is a while ago, I think we can assume it's in stable now? |
That is correct. There is a stable release now. |
@mispencer I have rebased this branch locally and pushed to my fork. However, I can't figure out what omnisharp is doing, as diagnostics and completion all seem pretty off from what ycmd expects in its tests. Here's a link https://github.com/bstaletic/ycmd/tree/OmnisharpLatest |
The version of Omnisharp-rosyln doesn't support .NET 6. To provide this support, we upgrade to the latest Omnisharp-roslyn, and use the .NET 6 build of it.
Issues not necessarily resolvable:
Current issues to be resolved:
This change is