Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSU-124] Improve facility show loading speed #5075

Merged
merged 1 commit into from
Mar 6, 2025
Merged

[OSU-124] Improve facility show loading speed #5075

merged 1 commit into from
Mar 6, 2025

Conversation

joaquinco
Copy link
Collaborator

@joaquinco joaquinco commented Mar 6, 2025 •
edited
Loading

Notes

  • Prevent N+1 by eager loading instruments' alerts and offline reservations on facility show. I had to move some associations from instrument to product
  • Some code improvement on product display groups

@joaquinco joaquinco marked this pull request as draft March 6, 2025 14:22
@joaquinco joaquinco force-pushed the osu-124/improve-facility-show-queries branch from 234d970 to 11f8b73 Compare March 6, 2025 14:23
@joaquinco joaquinco marked this pull request as ready for review March 6, 2025 14:35
LeticiaErrandonea
LeticiaErrandonea reviewed Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@LeticiaErrandonea LeticiaErrandonea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising 🤞

I left a couple of questions

LeticiaErrandonea
LeticiaErrandonea approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@LeticiaErrandonea LeticiaErrandonea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

@joaquinco joaquinco merged commit 5518cf4 into master Mar 6, 2025
3 checks passed
@joaquinco joaquinco deleted the osu-124/improve-facility-show-queries branch March 6, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeticiaErrandonea LeticiaErrandonea LeticiaErrandonea approved these changes

@diebas diebas Awaiting requested review from diebas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaquinco @LeticiaErrandonea