fix: Properly close readline instance on close (#1278)

wxt-dev · Dec 25, 2024 · 0bf7279 · 0bf7279
1 parent 62525d3
commit 0bf7279
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/packages/wxt/src/core/builders/vite/index.ts b/packages/wxt/src/core/builders/vite/index.ts
@@ -372,6 +372,9 @@ export async function createViteBuilder(
           },
         },
         watcher: viteServer.watcher,
+        on(event, cb) {
+          viteServer.httpServer?.on(event, cb);
+        },
       };
 
       return server;

diff --git a/packages/wxt/src/core/create-server.ts b/packages/wxt/src/core/create-server.ts
@@ -171,6 +171,8 @@ async function createServerInternal(): Promise<WxtDevServer> {
     await runner.openBrowser();
   };
 
+  builderServer.on?.('close', () => keyboardShortcuts.stop());
+
   return server;
 }
 

diff --git a/packages/wxt/src/types.ts b/packages/wxt/src/types.ts
@@ -1098,6 +1098,7 @@ export interface WxtBuilderServer {
    * Chokidar file watcher instance.
    */
   watcher: FSWatcher;
+  on?(event: string, callback: () => void): void;
 }
 
 export interface ServerInfo {
-Original file line number
+Diff line change
@@ Expand Up @@
         await runner.openBrowser();
       };
+      builderServer.on?.('close', () => keyboardShortcuts.stop());
       return server;
     }
@@ Expand Down @@