[BE] refactor: 이전의 review 테이블을 삭제하고, new_review 테이블만을 사용하도록 변경 #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results159 tests 156 ✅ 5s ⏱️ Results for commit b9c578d. ♻️ This comment has been updated with latest results. |
nayonsoso
requested changes
Feb 13, 2025
| -- 이전에 review 테이블 변경 사항 중 new_review가 아닌 review에 적용된 사항을 다시 반영합니다. | ||
| ALTER TABLE new_review ADD COLUMN member_id BIGINT NULL; | ||
|
|
||
| -- 기존 review 테이블을 삭제하고, ew_review 테이블의 이름을 "review"로 변경합니다. |
There was a problem hiding this comment.
Suggested change
| -- 기존 review 테이블을 삭제하고, ew_review 테이블의 이름을 "review"로 변경합니다. | |
| -- 기존 review 테이블을 삭제하고, new_review 테이블의 이름을 "review"로 변경합니다. |
Comment on lines
6
to
9
| BEGIN | ||
| DROP TABLE IF EXISTS review; | ||
| ALTER TABLE new_review RENAME TO review; | ||
| COMMIT |
There was a problem hiding this comment.
Suggested change
| BEGIN | |
| DROP TABLE IF EXISTS review; | |
| ALTER TABLE new_review RENAME TO review; | |
| COMMIT | |
| START TRANSACTION; | |
| DROP TABLE IF EXISTS review; | |
| ALTER TABLE new_review RENAME TO review; | |
| COMMIT; |
BEGIN은 일부 SQL 모드에서 자동 커밋을 끄지 않을 수도 있으므로,
START TRANSACTION 을 사용하는게 안전하다고 하네요!
nayonsoso
requested changes
Feb 13, 2025
There was a problem hiding this comment.
테드 자꾸 추가해서 미안한데,
flyway는 각 마이그레이션 스크립트가 자체적으로 하나의 트랜잭션으로 실행되어서
별도로 트랜잭션으로 묶을 필요가 없다고 합니다😅
Flyway wraps the execution of each migration script in a single transaction and applies them in order.
https://documentation.red-gate.com/fd/migration-transaction-handling-273973399.html
트랜잭션 부분 없애도 될 것 같아요!
이해완👍👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
🔥 어떻게 해결했나요 ?
📝 어떤 부분에 집중해서 리뷰해야 할까요?
📚 참고 자료, 할 말