[BE] refactor: 기존 api가 리뷰 그룹 정보를 포함하도록 수정 #1078
Merged
+205
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayonsoso
requested review from
donghoony,
Kimprodp and
skylar1220
as code owners
nayonsoso
commented
Jan 31, 2025
Comment on lines
28
to
+27
| @GetMapping("/v2/groups/summary") | ||
| public ResponseEntity<ReviewGroupResponse> getReviewGroupSummary(@RequestParam String reviewRequestCode) { | ||
| ReviewGroupResponse response = reviewGroupLookupService.getReviewGroupSummary(reviewRequestCode); | ||
| public ResponseEntity<ReviewGroupSummaryResponse> getReviewGroupSummary(@RequestParam String reviewRequestCode) { | ||
| ReviewGroupSummaryResponse response = reviewGroupLookupService.getReviewGroupSummary(reviewRequestCode); |
There was a problem hiding this comment.
회의에서
- 이 api 도 reviewGroupId 로 판별할까?🤔
- 리리코로 리뷰 그룹 정보를 식별해오는게 통일도 안된 것 같고 애매하긴 한데,..
호환성의 문제도 있고 복잡하니 일단 api 는 그대로 두고 response 이름만 변경하자! 😇
라고 했어서 반영했습니다~
Comment on lines
16
to
+18
| @GetMapping("/v2/sections") | ||
| public ResponseEntity<SectionNamesResponse> getSectionNames( | ||
| @ReviewGroupSession ReviewGroup reviewGroup | ||
| ) { | ||
| SectionNamesResponse sectionNames = templateService.getSectionNames(reviewGroup); | ||
| public ResponseEntity<SectionNamesResponse> getSectionNames() { | ||
| SectionNamesResponse sectionNames = templateService.getSectionNames(); |
There was a problem hiding this comment.
이 부분은 사실 회의에서 /templates/{templateId}/sections로 하자고 했었는데,
왜 테드가 기존 api 그대로 두고 고정 응답을 하자고 했는지 코드를 보면서 깨달았어요 ㅠ
templateId 를 받게 해봤자, templateId 를 지정해서 생성하는 곳도 없고, 응답으로 내려주는 곳도 없고...
지금 변경을 하더라도 맥락에 안맞는 변경 같더라고요😅
그래서 기존 내용대로 그대로 뒀습니다!
대신 defaultTemplate 관련된 내용이 응집도있게 존재할 수 있도록
DefaultTemplateService 를 만들어봤어요.
nayonsoso
force-pushed
the
be/refactor/1048-add-group-info-to-api
branch
from
0418229 to
63222d8
Compare
nayonsoso
changed the title
Kimprodp
approved these changes
Feb 11, 2025
nayonsoso
force-pushed
the
be/refactor/1048-add-group-info-to-api
branch
from
63222d8 to
bc05aac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
🔥 어떻게 해결했나요 ?
📝 어떤 부분에 집중해서 리뷰해야 할까요?