[1.2.0/ AN-UI, AN-FEAT] 배틀 날씨 효과 UI 변경 #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh1mj1
approved these changes
Dec 15, 2024
| @@ -78,6 +78,9 @@ class BattleViewModel( | |||
| battleResult.map { it.isSuccess() } | |||
| .stateIn(viewModelScope, SharingStarted.WhileSubscribed(5000), false) | |||
|
|
|||
| private val _showWeatherEffect = MutableStateFlow(false) | |||
There was a problem hiding this comment.
weatherEffectIsShown 이 더 나을까요?
이것도 나쁘지 않은데,
이것을 사용하는 클라이언트 코드에서 볼 때 빌더 메서드가 아닌 조정자 메서드 같아 보였어요.
There was a problem hiding this comment.
저도 동감합니다~ 근데 isShownWeatherEffect 이 어떠심? ㅋㅋㅋ
| @@ -29,6 +29,8 @@ enum class WeatherIcon( | |||
| TURBULENCE(R.drawable.icon_air), | |||
| } | |||
|
|
|||
| fun WeatherUiModel.hasWeatherEffect(): Boolean = effect.isNotBlank() && effect.isNotEmpty() | |||
There was a problem hiding this comment.
isNotBlank() 만 해도 isNotEmpty 케이스를 커버한다고 알고 있습니다.
murjune
approved these changes
Dec 18, 2024
| @@ -78,6 +78,9 @@ class BattleViewModel( | |||
| battleResult.map { it.isSuccess() } | |||
| .stateIn(viewModelScope, SharingStarted.WhileSubscribed(5000), false) | |||
|
|
|||
| private val _showWeatherEffect = MutableStateFlow(false) | |||
There was a problem hiding this comment.
저도 동감합니다~ 근데 isShownWeatherEffect 이 어떠심? ㅋㅋㅋ
kkosang
approved these changes
Dec 26, 2024
| @@ -75,19 +75,39 @@ class BattleActivity : ToolbarActivity<ActivityBattleBinding>(R.layout.activity_ | |||
| } | |||
|
|
|||
| private fun initObserver() { | |||
| observeWeathers() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 영상
Screen_recording_20241215_165047.mp4
작업한 내용
PR 포인트
🚀Next Feature