[1.2.0/AN-UI, AN-FEAT] 특성 목록 스크롤 시 앱 바 애니메이션 적용 #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murjune
approved these changes
Nov 28, 2024
Comment on lines
13
to
40
| <androidx.coordinatorlayout.widget.CoordinatorLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent"> | ||
|
|
||
| <com.google.android.material.appbar.MaterialToolbar | ||
| android:id="@+id/toolbar_ability" | ||
| style="@style/CustomToolbarStyle" | ||
| android:layout_width="0dp" | ||
| android:layout_height="?attr/actionBarSize" | ||
| android:contentInsetStartWithNavigation="0dp" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" | ||
| app:title="@string/ability_title_name"> | ||
|
|
||
| <androidx.appcompat.widget.SearchView | ||
| style="@style/CustomSearchViewStyle" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="end|center_vertical" | ||
| android:theme="@style/CustomSearchViewTheme" | ||
| app:onQueryTextChange="@{vm}" | ||
| app:queryHint="@string/ability_search_hint" /> | ||
|
|
||
| </com.google.android.material.appbar.MaterialToolbar> | ||
| android:layout_height="match_parent" | ||
| tools:context=".presentation.ability.AbilityActivity"> | ||
|
|
||
| <com.google.android.material.appbar.AppBarLayout | ||
| android:id="@+id/app_bar_ability" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:background="@color/poke_black" | ||
| app:liftOnScrollColor="@color/poke_black"> | ||
|
|
||
| <com.google.android.material.appbar.MaterialToolbar | ||
| android:id="@+id/toolbar_ability" | ||
| style="@style/CustomToolbarStyle" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| app:layout_scrollFlags="scroll|enterAlways" | ||
| app:title="@string/ability_title_name" | ||
| app:titleTextColor="@color/poke_white"> | ||
|
|
||
| <androidx.appcompat.widget.SearchView | ||
| style="@style/CustomSearchViewStyle" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="end|center_vertical" | ||
| app:onQueryTextChange="@{vm}" | ||
| app:queryHint="@string/ability_search_hint" /> |
There was a problem hiding this comment.
요 부분이군요!! 저도 바꾸겠습니당.. 하 내 시간 ㅋㅋㅋ
murjune
changed the title
sh1mj1
force-pushed
the
an/feat/ability-top-bar-collapsing
branch
from
6ce9471 to
4f031b0
Compare
kkosang
approved these changes
Dec 5, 2024
| @@ -10,51 +10,48 @@ | |||
| type="poke.rogue.helper.presentation.ability.AbilityViewModel" /> | |||
| </data> | |||
|
|
|||
|
|
|||
| <androidx.constraintlayout.widget.ConstraintLayout | |||
| <androidx.coordinatorlayout.widget.CoordinatorLayout | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 영상
Untitled.Video.mov
작업한 내용
PR 포인트
🚀Next Feature