[1.1.1/AN-FEAT] 포켓몬 상세에서 배틀 도우미로 가는 floating 버튼 추가(Revert 된 것 다시) #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue: 화면이 안나옴..
* feat(activity_pokemon_detail2): first coordinatorlayout * feat(activity_pokemon_detail2): title * chore: PokemonDetailActivity 안 쓰는 부분 일단 주석 * feat(PokemonDetail2Activity): 샘플 코드 가져와보기 * feat: activity_pokemon_detail2.xml 타입만 해결하면 되는데 * feat: OuterEvolutionAdapter, OuterEvolutionViewHolder * feat: 진화 프래그먼트 outer evolutions 로 변경 issue: 화면이 안나옴.. * fix: feat: 진화 프래그먼트 outer evolutions 로 , 화면 나옴 * fix: activity_pokemon_detail2 의 nestedScrollview 를 각 프래그먼트로 이동 * chore: ktlint, 사용하지 않는 파일 제거 * chore: ktlint, 사용하지 않는 파일 제거 * refactor(EvolutionsUiModel): ui 에서 사용하는 리스트로 변환 * refactor(EvolutionStageAdapter): 네이밍 * fix: activity_pokemon_detail.xml 최상단일 때만 상단이 가려진다 fix: #369 (review) * chore: 로그 삭제 * fix(activity_pokemon_detail): progress indicator 위치 조정
sh1mj1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 영상
작업한 내용
Revert 된 [1.1.1/AN-FEAT] 포켓몬 상세에서 배틀 도우미로 가는 floating 버튼 추가 PR 입니다.
PR 포인트
🚀Next Feature