Skip to content

Commit

Permalink
Merge pull request #134 from woowacourse-teams/be/refactor/#128-refac…
Browse files Browse the repository at this point in the history
…tor-type-query

[BE-REFACTOR] PokemonType 쿼리 개선
  • Loading branch information
dwax1324 authored Aug 4, 2024
2 parents 490bf00 + f401a2f commit a6eb1da
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,19 @@
package com.pokerogue.helper.type.repository;

import com.pokerogue.helper.type.domain.PokemonTypeMatching;
import java.util.List;
import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.data.jpa.repository.Query;
import org.springframework.lang.NonNull;

public interface PokemonTypeMatchingRepository extends JpaRepository<PokemonTypeMatching, Long> {

@Override
@NonNull
@Query("""
select ptm from PokemonTypeMatching ptm
join fetch ptm.toType tt
join fetch ptm.fromType ft
""")
List<PokemonTypeMatching> findAll();
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package com.pokerogue.helper.type.repository;

import static org.junit.jupiter.api.Assertions.*;

import com.pokerogue.environment.repository.RepositoryTest;
import com.pokerogue.helper.type.domain.PokemonTypeMatching;
import java.util.List;
import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;

class PokemonTypeMatchingRepositoryTest extends RepositoryTest {

@Autowired
private PokemonTypeMatchingRepository pokemonTypeMatchingRepository;


/*
PR: [BE-REFACTOR] Pokemon 쿼리 개선 #133
위 PR이 먼저 머지되어야 실행 가능한 테스트라서 주석 처리함.
*/
// @Test
// @DisplayName("포켓몬의 모든 타입 매칭 정보를 조회한다.")
// void findAll() {
// List<PokemonTypeMatching> pokemonTypeMatchings = pokemonTypeMatchingRepository.findAll();
//
// Assertions.assertThat(pokemonTypeMatchings).isNotEmpty();
// }

}

0 comments on commit a6eb1da

Please sign in to comment.