Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 로깅 처리 추가 #626

Merged
merged 3 commits into from
Oct 19, 2022
Merged

feat: 로깅 처리 추가 #626

merged 3 commits into from
Oct 19, 2022

Conversation

yeon-06
Copy link
Collaborator

@yeon-06 yeon-06 commented Oct 18, 2022

요약

로깅 처리 추가



작업 내용

controller의 메서드가 실행되는 경우 클래스명, 메서드명, 파라미터 값을 출력합니다



참고 사항

profile별로 level을 다르게 설정하고 싶었는데 기존의 로그 설정 내역을 이해할 수 없어 보류해두었습니다.
내일 봄에게 물어보고 수정하겠습니다ㅜ.ㅜ

#639



@yeon-06 yeon-06 added 🎉 BE 백엔드 관련 ✨ FEAT labels Oct 18, 2022
@yeon-06 yeon-06 requested review from JangBomi and hyewoncc October 18, 2022 11:51
@yeon-06 yeon-06 self-assigned this Oct 18, 2022
@github-actions
Copy link

github-actions bot commented Oct 18, 2022

Unit Test Results

200 tests   200 ✔️  20s ⏱️
  67 suites      0 💤
  67 files        0

Results for commit 53045d7.

♻️ This comment has been updated with latest results.

@pickpick-sonarqube

This comment has been minimized.

@yeon-06 yeon-06 marked this pull request as draft October 18, 2022 12:05
@pickpick-sonarqube

This comment has been minimized.

@pickpick-sonarqube

This comment has been minimized.

1 similar comment
@pickpick-sonarqube

This comment has been minimized.

@yeon-06 yeon-06 force-pushed the feature/add-logging branch from 7f88cb0 to 53045d7 Compare October 19, 2022 05:49
@pickpick-sonarqube
Copy link

Passed

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 91.67% Coverage (89.60% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: woowacourse-teams_2022-pickpick_AYKprLeNXDQxKhlck1fc

View in SonarQube

@yeon-06 yeon-06 marked this pull request as ready for review October 19, 2022 05:56
Copy link
Collaborator

@hyewoncc hyewoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

첫 커스텀 AOP 적용이군요!!! 수고하셨어요 🎉🎉🎉

Copy link
Collaborator

@JangBomi JangBomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AOP 적용 👍 최고에요

@JangBomi JangBomi merged commit cdb3c1d into develop Oct 19, 2022
@JangBomi JangBomi deleted the feature/add-logging branch October 19, 2022 06:03
@yeon-06 yeon-06 linked an issue Oct 19, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 BE 백엔드 관련 ✨ FEAT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

로깅 추가
3 participants