fix pageToken handling #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered a small bug in page token handling when looking at the crawler a few days ago. For paged queries, 'nextPageToken' is sent as a param to search API, but actually 'pageToken' is the correct input param name (even though nextPageToken/prevPageToken are what's returned). Ref https://developers.google.com/youtube/v3/docs/search/list#pageToken
I found this was causing paging to not work correctly - the first queries were being duplicated without proceeding onto the next page. This was mainly triggered with query efficiency modifications I had to make because my API limits were very low, but I believe it could be triggered under certain conditions with existing query planning if many videos under min duration are returned.
Thanks!