Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add wikibase-lts and deploy-lts products #813

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

chore: Add wikibase-lts and deploy-lts products #813

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a9d20b
chore: Add wikibase-lts and deploy-lts products
lorenjohnson Jan 6, 2025
475d837
chore: Prepare initial LTS product releases
lorenjohnson Jan 6, 2025
adaaea4
chore: Update nx to see the deploy-lts package/product
lorenjohnson Jan 6, 2025
1f8648f
chore: Add LTS product variants as options to GHA Create a WBS Release
lorenjohnson Jan 6, 2025
a5d66f1
Merge branch 'main' into lts-product
lorenjohnson Jan 7, 2025
c0232cb
chore: Removes -lts post fix from the image name published to Dockerhub
lorenjohnson Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion build/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,12 @@ else
)
fi

# transform TAGS to build args
IMAGE_NAME=$(jq -r '.name' package.json)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also just change the name in package.json? Without any code change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think this is not a good idea. I think we need to keep the -lts around until we finally publish to dockerhub only. Otherwise we need to change too many things, e.g. local image versioning vs latest only, how to identify images when pushed to/pulled from GHCR...


# Removes "-lts" from end of name if it exists.
# LTS products are released on Dockerhub on the main image name
IMAGE_NAME=${IMAGE_NAME%-lts}

# publish to Dockerhub
if [ "$PUBLISH" == true ]; then
# IMAGE_REGISTRY implies dockerhub if empty
Expand Down
Loading