Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nanobind_setup_libname helper function #858

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Added nanobind_setup_libname helper function #858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 40 additions & 15 deletions cmake/nanobind-config.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,35 @@ function (nanobind_musl_static_libcpp name)
endif()
endfunction()

function (
nanobind_setup_libname
output_libname
ARG_NB_STATIC
ARG_STABLE_ABI
ARG_FREE_THREADED
ARG_NB_DOMAIN
ARG_NB_SHARED
)
set(libname "nanobind")
if (ARG_NB_STATIC)
set(libname "${libname}-static")
endif()

if (ARG_STABLE_ABI)
set(libname "${libname}-abi3")
endif()

if (ARG_FREE_THREADED)
set(libname "${libname}-ft")
endif()

if (ARG_NB_DOMAIN AND ARG_NB_SHARED)
set(libname ${libname}-${ARG_NB_DOMAIN})
endif()

set(${output_libname} ${libname} PARENT_SCOPE)
endfunction()

function(nanobind_add_module name)
cmake_parse_arguments(PARSE_ARGV 1 ARG
"STABLE_ABI;FREE_THREADED;NB_STATIC;NB_SHARED;PROTECT_STACK;LTO;NOMINSIZE;NOSTRIP;MUSL_DYNAMIC_LIBCPP"
Expand Down Expand Up @@ -338,22 +367,18 @@ function(nanobind_add_module name)
set(ARG_FREE_THREADED FALSE)
endif()

set(libname "nanobind")
if (ARG_NB_STATIC)
set(libname "${libname}-static")
endif()

if (ARG_STABLE_ABI)
set(libname "${libname}-abi3")
endif()

if (ARG_FREE_THREADED)
set(libname "${libname}-ft")
endif()

if (ARG_NB_DOMAIN AND ARG_NB_SHARED)
set(libname ${libname}-${ARG_NB_DOMAIN})
# Avoid passing empty argument which will lead to an error when calling nanobind_setup_libname
if (NOT ARG_NB_DOMAIN)
set(ARG_NB_DOMAIN FALSE)
endif()
nanobind_setup_libname(
libname
${ARG_NB_STATIC}
${ARG_STABLE_ABI}
${ARG_FREE_THREADED}
${ARG_NB_SHARED}
${ARG_NB_DOMAIN}
)

nanobind_build_library(${libname})

Expand Down
Loading