Refactor launcher #1573
Open
Refactor launcher #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sajjon
commented
Feb 22, 2025
| @@ -0,0 +1,36 @@ | |||
| pub(super) mod prelude { | |||
There was a problem hiding this comment.
I'm no module expert - so most likely this can be improved.
Sajjon
commented
Feb 22, 2025
| .padding(100) | ||
| } | ||
|
|
||
| fn with_children<'a>(&'a self, content: Element<'a, Message>) -> Element<'a, Message> { |
There was a problem hiding this comment.
I could not elide those lifetimes, maybe someone else knows better....
Sajjon
commented
Feb 22, 2025
| ) | ||
| } | ||
|
|
||
| fn view_no_wallet(&self) -> Column<ViewMessage> { |
There was a problem hiding this comment.
view_no_wallet could probably be split even more.
Sajjon
commented
Feb 22, 2025
| ) | ||
| } | ||
|
|
||
| fn view_wallet( |
There was a problem hiding this comment.
view_wallet could probably be split even more.
Sajjon
commented
Feb 22, 2025
| Deleted, | ||
| } | ||
|
|
||
| pub(super) struct DeleteWalletModal { |
There was a problem hiding this comment.
DeleteWalletModal can be split out too, into children module of launcher module.
Sajjon
commented
Feb 22, 2025
| } | ||
| } | ||
|
|
||
| fn handle_view(&mut self, view_message: ViewMessage) -> Option<Task<Message>> { |
There was a problem hiding this comment.
Full exhaustive, less indented handling of ViewMessages only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This is an opinionated refactoring of the
Launcherfeature - I completely understand if you dislike/hatethis style!
I'm new to GUI in Rust and Iced - but I've developed Redux styled applications in SwiftUI using TCA for many years, where it is quite a common pattern to split:
updatemethods into smaller sub-update methodsWhich is what I've done in this PR - mostly to ask for input if it is something you as maintainers of Liana or the ICED community in large likes?
Tip
The advantages of this approach is two fold:
Other changes